Update Natural GeoH2 with Yearly CF#552
Conversation
jmartin4u
left a comment
There was a problem hiding this comment.
Looks wonderful. Can we just change the example script, examples\04_geo_h2\run_geo_h2.py, so that it shows the yearly decline curve rather than a flat hourly curve over one year? Paste these lines in over lines 14-20 to see what I'm talking about:
hydrogen_out = h2i_nat.prob.model.plant.geoh2_well_subsurface.NaturalGeoH2PerformanceModel.get_val(
"annual_hydrogen_produced", units="t/year"
)
plt.plot(hydrogen_out)
plt.xlabel("Year")
plt.ylabel("Hydrogen Production (tonne per annum)")
plt.title("Hydrogen Production over Well Lifetime")
If you can change the X axis to start on the analysis_start_year rather than zero that would be great, I couldn't quickly figure out how to do that.
Changed! And @elenya-grant was able to figure out how to use the |
Update Natural GeoH2 with Yearly CF
This PR updates the
NaturalGeoH2PerformanceModelto output yearly metrics for thecapacity_factorandannual_hydrogen_produced. The finance model update in PR #543 enabled the ability to use the lifetime performance in the financial calculations.NOTE: The
hydrogen_outis still the average hydrogen output over the well lifetime. This is because of an issue documented in #475.Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.mdhas been updated to describe the changes made in this PRSection 3: Related Issues
#475 still an active issue.
Section 4: Impacted Areas of the Software
Section 4.1: New Files
N/A
Section 4.2: Modified Files
h2integrate/converters/hydrogen/geologic/simple_natural_geoh2.pycapacity_factorandannual_hydrogen_produced.capacity_factoris subsequently used in financial calculations.h2integrate/converters/hydrogen/geologic/test/test_geologic_hydrogen.pyNaturalGeoH2PerformanceModel.examples/test/test_all_examples.pySection 5: Additional Supporting Information
Section 6: Test Results, if applicable
Section 7 (Optional): New Model Checklist
docs/developer_guide/coding_guidelines.mdattrsclass to define theConfigto load in attributes for the modelBaseConfigorCostModelBaseConfiginitialize()method,setup()method,compute()methodCostModelBaseClasssupported_models.pycreate_financial_modelinh2integrate_model.pytest_all_examples.pydocs/user_guide/model_overview.mddocs/section<model_name>.mdis added to the_toc.yml